stream: ensuring cross-destruction in _duplexify to prevent leaks

watilde · aduh95 · commit d0c913758abd · 2026-05-07T15:41:43.000+02:00
PR-URL: #62824 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
diff --git a/lib/internal/streams/duplexify.js b/lib/internal/streams/duplexify.js
@@ -334,7 +334,7 @@ function _duplexify(pair) {
     eos(r, (err) => {
       readable = false;
       if (err) {
-        destroyer(r, err);
+        destroyer(w, err);
       }
       onfinished(err);
     });
diff --git a/test/parallel/test-stream-duplex-from.js b/test/parallel/test-stream-duplex-from.js
@@ -401,3 +401,20 @@ function makeATestWritableStream(writeFunc) {
     assert.strictEqual(d.writable, false);
   }));
 }
+
+// When the readable side errors, the error must propagate to the writable side.
+{
+  const expectedErr = new Error('readable error');
+  const r = new Readable({ read() {} });
+  const w = new Writable({
+    write(chunk, encoding, callback) { callback(); },
+  });
+  const d = Duplex.from({ readable: r, writable: w });
+  d.on('error', common.mustCall((err) => {
+    assert.strictEqual(err, expectedErr);
+  }));
+  w.on('error', common.mustCall((err) => {
+    assert.strictEqual(err, expectedErr);
+  }));
+  r.destroy(expectedErr);
+}
