module: use kNodeModulesRE to detect node_modules

joyeecheung · marco-ippolito · commit cf8701c866cb · 2025-02-11T11:56:39.000+01:00
This is faster and more consistent with other places using the regular expression to detect node_modules. PR-URL: #55243 Backport-PR-URL: #56927 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Refs: #52697
diff --git a/lib/internal/modules/esm/load.js b/lib/internal/modules/esm/load.js
@@ -5,7 +5,9 @@ const {
   RegExpPrototypeExec,
   decodeURIComponent,
 } = primordials;
-const { kEmptyObject } = require('internal/util');
+const {
+  kEmptyObject,
+} = require('internal/util');
 
 const { defaultGetFormat } = require('internal/modules/esm/get_format');
 const { validateAttributes, emitImportAssertionWarning } = require('internal/modules/esm/assert');
diff --git a/lib/internal/util.js b/lib/internal/util.js
@@ -477,6 +477,10 @@ function spliceOne(list, index) {
 
 const kNodeModulesRE = /^(?:.*)[\\/]node_modules[\\/]/;
 
+function isUnderNodeModules(filename) {
+  return filename && (RegExpPrototypeExec(kNodeModulesRE, filename) !== null);
+}
+
 let getStructuredStackImpl;
 
 function lazyGetStructuredStack() {
@@ -524,7 +528,7 @@ function isInsideNodeModules() {
       ) {
         continue;
       }
-      return RegExpPrototypeExec(kNodeModulesRE, filename) !== null;
+      return isUnderNodeModules(filename);
     }
   }
   return false;
@@ -913,6 +917,7 @@ module.exports = {
   isArrayBufferDetached,
   isError,
   isInsideNodeModules,
+  isUnderNodeModules,
   join,
   lazyDOMException,
   lazyDOMExceptionClass,
