http2: do not falsely emit 'aborted' on push

apapirovski · BethGriggs · commit ca933ce57783 · 2018-10-17T00:07:24.000+01:00
A push stream should have its writable side closed upon receipt, to avoid emitting the 'aborted' event when the readable side is closed. Backport-PR-URL: #22850 PR-URL: #22878 Fixes: #22851 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
diff --git a/lib/internal/http2/core.js b/lib/internal/http2/core.js
@@ -220,6 +220,7 @@ function onSessionHeaders(handle, id, cat, flags, headers) {
       }
     } else {
       stream = new ClientHttp2Stream(session, handle, id, opts);
+      stream.end();
     }
     if (endOfStream)
       stream[kState].endAfterHeaders = true;
diff --git a/test/parallel/test-http2-server-push-stream.js b/test/parallel/test-http2-server-push-stream.js
@@ -54,6 +54,7 @@ server.listen(0, common.mustCall(() => {
       assert.strictEqual(headers['content-type'], 'text/html');
       assert.strictEqual(headers['x-push-data'], 'pushed by server');
     }));
+    stream.on('aborted', common.mustNotCall());
   }));
 
   let data = '';

Original file line number	Diff line number	Diff line change
`@@ -220,6 +220,7 @@ function onSessionHeaders(handle, id, cat, flags, headers) {`
`220`	`220`	`}`
`221`	`221`	`} else {`
`222`	`222`	`stream = new ClientHttp2Stream(session, handle, id, opts);`
	`223`	`+ stream.end();`
`223`	`224`	`}`
`224`	`225`	`if (endOfStream)`
`225`	`226`	`stream[kState].endAfterHeaders = true;`