lib: the REPL should survive deletion of Array.prototype methods

ljharb · marco-ippolito · commit c96e5cb66413 · 2024-11-17T11:51:28.000+01:00
Specifically, `delete Array.prototype.lastIndexOf` immediately crashes the REPL, as does deletion of a few other Array prototype methods. PR-URL: #31457 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
diff --git a/lib/domain.js b/lib/domain.js
@@ -40,6 +40,7 @@ const {
   ReflectApply,
   SafeMap,
   SafeWeakMap,
+  StringPrototypeRepeat,
   Symbol,
 } = primordials;
 
@@ -131,7 +132,7 @@ const domainRequireStack = new Error('require(`domain`) at this point').stack;
 const { setUncaughtExceptionCaptureCallback } = process;
 process.setUncaughtExceptionCaptureCallback = function(fn) {
   const err = new ERR_DOMAIN_CANNOT_SET_UNCAUGHT_EXCEPTION_CAPTURE();
-  err.stack = err.stack + '\n' + '-'.repeat(40) + '\n' + domainRequireStack;
+  err.stack += `\n${StringPrototypeRepeat('-', 40)}\n${domainRequireStack}`;
   throw err;
 };
 
diff --git a/lib/repl.js b/lib/repl.js
@@ -1528,15 +1528,15 @@ function complete(line, callback) {
         let p;
         if ((typeof obj === 'object' && obj !== null) ||
             typeof obj === 'function') {
-          memberGroups.push(filteredOwnPropertyNames(obj));
+          ArrayPrototypePush(memberGroups, filteredOwnPropertyNames(obj));
           p = ObjectGetPrototypeOf(obj);
         } else {
           p = obj.constructor ? obj.constructor.prototype : null;
         }
         // Circular refs possible? Let's guard against that.
         let sentinel = 5;
         while (p !== null && sentinel-- !== 0) {
-          memberGroups.push(filteredOwnPropertyNames(p));
+          ArrayPrototypePush(memberGroups, filteredOwnPropertyNames(p));
           p = ObjectGetPrototypeOf(p);
         }
       } catch {
