src: print backtrace on abort/unreachable code

bnoordhuis · Fishrock123 · commit c96d701769a8 · 2016-07-05T22:36:48.000+02:00
Print a C backtrace on fatal errors to make it easier to debug issues. PR-URL: #6734 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
diff --git a/src/node.cc b/src/node.cc
@@ -2452,7 +2452,6 @@ static void OnFatalError(const char* location, const char* message) {
   } else {
     PrintErrorString("FATAL ERROR: %s\n", message);
   }
-  DumpBacktrace(stderr);
   fflush(stderr);
   ABORT();
 }
diff --git a/src/util.h b/src/util.h
@@ -38,11 +38,18 @@ template <typename T> using remove_reference = std::remove_reference<T>;
 
 // Windows 8+ does not like abort() in Release mode
 #ifdef _WIN32
-#define ABORT() raise(SIGABRT)
+#define ABORT_NO_BACKTRACE() raise(SIGABRT)
 #else
-#define ABORT() abort()
+#define ABORT_NO_BACKTRACE() abort()
 #endif
 
+#define ABORT()                                                               \
+  do {                                                                        \
+    node::DumpBacktrace(stderr);                                              \
+    fflush(stderr);                                                           \
+    ABORT_NO_BACKTRACE();                                                     \
+  } while (0)
+
 #if defined(NDEBUG)
 # define ASSERT(expression)
 # define CHECK(expression)                                                    \

Original file line number	Diff line number	Diff line change
`@@ -2452,7 +2452,6 @@ static void OnFatalError(const char* location, const char* message) {`
`2452`	`2452`	`} else {`
`2453`	`2453`	`PrintErrorString("FATAL ERROR: %s\n", message);`
`2454`	`2454`	`}`
`2455`		`- DumpBacktrace(stderr);`
`2456`	`2455`	`fflush(stderr);`
`2457`	`2456`	`ABORT();`
`2458`	`2457`	`}`