lib: refactor source map stack trace prepare

VoltrexKeyva · danielleadams · commit c93a9af82b5f · 2022-03-14T09:32:10.000-04:00
• Make use of the logical OR operator (`||`) for better readability. • Remove unnecessary conditional and wrapping. PR-URL: #41698 Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
diff --git a/lib/internal/source_map/prepare_stack_trace.js b/lib/internal/source_map/prepare_stack_trace.js
@@ -89,12 +89,12 @@ const prepareStackTrace = (globalThis, error, trace) => {
           // Construct call site name based on: v8.dev/docs/stack-trace-api:
           const fnName = t.getFunctionName() ?? t.getMethodName();
           const originalName = `${t.getTypeName() !== 'global' ?
-            `${t.getTypeName()}.` : ''}${fnName ? fnName : '<anonymous>'}`;
+            `${t.getTypeName()}.` : ''}${fnName || '<anonymous>'}`;
           // The original call site may have a different symbol name
           // associated with it, use it:
           const prefix = (name && name !== originalName) ?
             `${name}` :
-            `${originalName ? originalName : ''}`;
+            `${originalName}`;
           const hasName = !!(name || originalName);
           const originalSourceNoScheme =
             StringPrototypeStartsWith(originalSource, 'file://') ?
@@ -160,7 +160,7 @@ function getErrorSource(
   let prefix = '';
   for (const character of new SafeStringIterator(
     StringPrototypeSlice(line, 0, originalColumn + 1))) {
-    prefix += (character === '\t') ? '\t' :
+    prefix += character === '\t' ? '\t' :
       StringPrototypeRepeat(' ', getStringWidth(character));
   }
   prefix = StringPrototypeSlice(prefix, 0, -1); // The last character is '^'.
