fs: fix getDirent().parentPath when type is UV_DIRENT_UNKNOWN

LiviaMedeiros · web-flow · commit c91ce2120c5c · 2024-11-16T23:23:58.000Z
PR-URL: #55553 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
diff --git a/lib/internal/fs/utils.js b/lib/internal/fs/utils.js
@@ -301,7 +301,7 @@ function getDirent(path, name, type, callback) {
           callback(err);
           return;
         }
-        callback(null, new DirentFromStats(name, stats, filepath));
+        callback(null, new DirentFromStats(name, stats, path));
       });
     } else {
       callback(null, new Dirent(name, type, path));
diff --git a/test/parallel/test-fs-utils-get-dirents.js b/test/parallel/test-fs-utils-get-dirents.js
@@ -75,6 +75,7 @@ const filename = 'foo';
     common.mustCall((err, dirent) => {
       assert.strictEqual(err, null);
       assert.strictEqual(dirent.name, filename);
+      assert.strictEqual(dirent.parentPath, tmpdir.path);
     },
     ));
 }
@@ -100,20 +101,22 @@ const filename = 'foo';
     common.mustCall((err, dirent) => {
       assert.strictEqual(err, null);
       assert.strictEqual(dirent.name, filenameBuffer);
-      assert.deepStrictEqual(dirent.parentPath, Buffer.from(tmpdir.resolve(`${filename}/`)));
+      assert.strictEqual(dirent.parentPath, tmpdir.path);
     },
     ));
 }
 {
   // Buffer + Buffer
   const filenameBuffer = Buffer.from(filename);
+  const dirnameBuffer = Buffer.from(tmpdir.path);
   getDirent(
-    Buffer.from(tmpdir.path),
+    dirnameBuffer,
     filenameBuffer,
     UV_DIRENT_UNKNOWN,
     common.mustCall((err, dirent) => {
       assert.strictEqual(err, null);
       assert.strictEqual(dirent.name, filenameBuffer);
+      assert.deepStrictEqual(dirent.parentPath, dirnameBuffer);
     },
     ));
 }

Original file line number	Diff line number	Diff line change
`@@ -301,7 +301,7 @@ function getDirent(path, name, type, callback) {`
`301`	`301`	`callback(err);`
`302`	`302`	`return;`
`303`	`303`	`}`
`304`		`- callback(null, new DirentFromStats(name, stats, filepath));`
	`304`	`+ callback(null, new DirentFromStats(name, stats, path));`
`305`	`305`	`});`
`306`	`306`	`} else {`
`307`	`307`	`callback(null, new Dirent(name, type, path));`