test: ensure NODE_EXTRA_CA_CERTS not set before tests

KrayzeeKev · danielleadams · commit c782c3dc69b1 · 2022-07-25T21:43:42.000-04:00
The 'test-tls-env-extra-ca-file-load.js' test assumes that NODE_EXTRA_CA_CERTS is not set. If the build environment happens to have it set, this test will fail. This change deletes that env var before running the test. PR-URL: #43858 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
diff --git a/test/parallel/test-tls-env-extra-ca-file-load.js b/test/parallel/test-tls-env-extra-ca-file-load.js
@@ -20,6 +20,8 @@ if (process.argv[2] !== 'child') {
   const NODE_EXTRA_CA_CERTS = fixtures.path('keys', 'ca1-cert.pem');
   const extendsEnv = (obj) => ({ ...process.env, ...obj });
 
+  // Remove any pre-existing extra CA certs.
+  delete process.env.NODE_EXTRA_CA_CERTS;
   [
     extendsEnv({ CHILD_USE_EXTRA_CA_CERTS: 'yes', NODE_EXTRA_CA_CERTS }),
     extendsEnv({ CHILD_USE_EXTRA_CA_CERTS: 'no' }),

Original file line number	Diff line number	Diff line change
`@@ -20,6 +20,8 @@ if (process.argv[2] !== 'child') {`
`20`	`20`	`const NODE_EXTRA_CA_CERTS = fixtures.path('keys', 'ca1-cert.pem');`
`21`	`21`	`const extendsEnv = (obj) => ({ ...process.env, ...obj });`
`22`	`22`
	`23`	`+ // Remove any pre-existing extra CA certs.`
	`24`	`+ delete process.env.NODE_EXTRA_CA_CERTS;`
`23`	`25`	`[`
`24`	`26`	`extendsEnv({ CHILD_USE_EXTRA_CA_CERTS: 'yes', NODE_EXTRA_CA_CERTS }),`
`25`	`27`	`extendsEnv({ CHILD_USE_EXTRA_CA_CERTS: 'no' }),`