v8: add GCProfiler support for erm

IlyasShabi · aduh95 · commit c75ad3d87dfd · 2026-01-22T14:46:34.000+01:00
PR-URL: #61191 Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
diff --git a/doc/api/v8.md b/doc/api/v8.md
@@ -1471,6 +1471,7 @@ added:
 -->
 
 Create a new instance of the `v8.GCProfiler` class.
+This API supports `using` syntax.
 
 ### `profiler.start()`
 
@@ -1490,7 +1491,7 @@ added:
   - v18.15.0
 -->
 
-Stop collecting GC data and return an object.The content of object
+Stop collecting GC data and return an object. The content of object
 is as follows.
 
 ```json
@@ -1575,6 +1576,14 @@ setTimeout(() => {
 }, 1000);
 ```
 
+### `profiler[Symbol.dispose]()`
+
+<!-- YAML
+added: REPLACEME
+-->
+
+Stop collecting GC data, and discard the profile.
+
 ## Class: `SyncCPUProfileHandle`
 
 <!-- YAML
diff --git a/lib/v8.js b/lib/v8.js
@@ -488,6 +488,10 @@ class GCProfiler {
       return JSONParse(data);
     }
   }
+
+  [SymbolDispose]() {
+    this.stop();
+  }
 }
 
 module.exports = {
diff --git a/test/parallel/test-v8-collect-gc-profile-using.js b/test/parallel/test-v8-collect-gc-profile-using.js
@@ -0,0 +1,26 @@
+'use strict';
+
+require('../common');
+const assert = require('assert');
+const { GCProfiler } = require('v8');
+
+{
+  const profiler = new GCProfiler();
+  profiler.start();
+
+  const result = profiler[Symbol.dispose]();
+
+  assert.strictEqual(result, undefined);
+  assert.strictEqual(profiler.stop(), undefined);
+}
+
+{
+  const profiler = new GCProfiler();
+  profiler.start();
+
+  profiler[Symbol.dispose]();
+  // Repeat invocations should not throw
+  profiler[Symbol.dispose]();
+
+  assert.strictEqual(profiler.stop(), undefined);
+}

Original file line number	Diff line number	Diff line change
`@@ -488,6 +488,10 @@ class GCProfiler {`
`488`	`488`	`return JSONParse(data);`
`489`	`489`	`}`
`490`	`490`	`}`
	`491`	`+`
	`492`	`+ [SymbolDispose]() {`
	`493`	`+ this.stop();`
	`494`	`+ }`
`491`	`495`	`}`
`492`	`496`
`493`	`497`	`module.exports = {`