inspector: mark profile type const

gengjiawen · targos · commit c7461567cea0 · 2019-05-20T13:20:18.000+02:00
PR-URL: #27712 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
diff --git a/src/inspector_profiler.h b/src/inspector_profiler.h
@@ -75,7 +75,7 @@ class V8CoverageConnection : public V8ProfilerConnection {
   void Start() override;
   void End() override;
 
-  const char* type() const override { return type_.c_str(); }
+  const char* type() const override { return "coverage"; }
   bool ending() const override { return ending_; }
 
   std::string GetDirectory() const override;
@@ -85,7 +85,6 @@ class V8CoverageConnection : public V8ProfilerConnection {
  private:
   std::unique_ptr<inspector::InspectorSession> session_;
   bool ending_ = false;
-  std::string type_ = "coverage";
 };
 
 class V8CpuProfilerConnection : public V8ProfilerConnection {
@@ -96,7 +95,7 @@ class V8CpuProfilerConnection : public V8ProfilerConnection {
   void Start() override;
   void End() override;
 
-  const char* type() const override { return type_.c_str(); }
+  const char* type() const override { return "CPU"; }
   bool ending() const override { return ending_; }
 
   std::string GetDirectory() const override;
@@ -106,7 +105,6 @@ class V8CpuProfilerConnection : public V8ProfilerConnection {
  private:
   std::unique_ptr<inspector::InspectorSession> session_;
   bool ending_ = false;
-  std::string type_ = "CPU";
 };
 
 }  // namespace profiler
