src: allow --perf-prof-unwinding-info in NODE_OPTIONS

tomgco · addaleax · commit c72c4b041dfa · 2019-02-09T00:44:35.000+01:00
PR-URL: #25565 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
diff --git a/doc/api/cli.md b/doc/api/cli.md
@@ -714,6 +714,7 @@ V8 options that are allowed are:
 - `--perf-basic-prof`
 - `--perf-basic-prof-only-functions`
 - `--perf-prof`
+- `--perf-prof-unwinding-info`
 - `--stack-trace-limit`
 
 ### `NODE_PATH=path[:&hellip;]`
diff --git a/src/node_options.cc b/src/node_options.cc
@@ -304,6 +304,10 @@ PerIsolateOptionsParser::PerIsolateOptionsParser() {
             V8Option{},
             kAllowedInEnvironment);
   AddOption("--perf-prof", "", V8Option{}, kAllowedInEnvironment);
+  AddOption("--perf-prof-unwinding-info",
+            "",
+            V8Option{},
+            kAllowedInEnvironment);
   AddOption("--stack-trace-limit", "", V8Option{}, kAllowedInEnvironment);
 
 #ifdef NODE_REPORT
diff --git a/test/parallel/test-cli-node-options.js b/test/parallel/test-cli-node-options.js
@@ -44,6 +44,7 @@ if (!common.isWindows) {
 if (common.isLinux && ['arm', 'x64'].includes(process.arch)) {
   // PerfJitLogger is only implemented in Linux.
   expect('--perf-prof', 'B\n');
+  expect('--perf-prof-unwinding-info', 'B\n');
 }
 
 if (common.hasCrypto) {

Original file line number	Diff line number	Diff line change
`@@ -44,6 +44,7 @@ if (!common.isWindows) {`
`44`	`44`	`if (common.isLinux && ['arm', 'x64'].includes(process.arch)) {`
`45`	`45`	`// PerfJitLogger is only implemented in Linux.`
`46`	`46`	`expect('--perf-prof', 'B\n');`
	`47`	`+ expect('--perf-prof-unwinding-info', 'B\n');`
`47`	`48`	`}`
`48`	`49`
`49`	`50`	`if (common.hasCrypto) {`