deps: V8: backport 9fb4444bfc46 · nodejs/node@c507c5a · GitHub
Skip to content

Commit c507c5a

Browse files
srl295aduh95
authored andcommitted
deps: V8: backport 9fb4444bfc46
Original commit message: Fix Temporal compilation with system or no ICU build: Fix Temporal compilation with system or no ICU Add new build flag, v8_enable_temporal_systemicu, off by default When on, it will remove references to the internal ICU udatamem.h header file Obviates CLs 7769990 / 7831715 See: https://unicode-org.atlassian.net/browse/ICU-23400 See: Node: #62676 See: V8: https://chromium-review.googlesource.com/c/v8/v8/+/7831715 See: Homebrew: Homebrew/homebrew-core#281707 Change-Id: Ibc460c68189d32e154c53eddfcda56bc7bca4fc6 Also includes: fix: fix for no-icu build thanks @aduh95 #62676 (comment) NO_IFTTT=No Temporal via Bazel Change-Id: Ibc460c68189d32e154c53eddfcda56bc7bca4fc6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/8281487 Reviewed-by: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Chengzhong Wu <cwu631@bloomberg.net> Reviewed-by: Olivier Flückiger <olivf@chromium.org> Cr-Commit-Position: refs/heads/main@{#110039} Refs: v8/v8@9fb4444 PR-URL: #65992 Fixes: #62676 Refs: srl295/v8@cd89fe6 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Richard Lau <richard.lau@ibm.com>
1 parent e0d0c5d commit c507c5a

5 files changed

Lines changed: 54 additions & 5 deletions

File tree

‎common.gypi‎

Lines changed: 1 addition & 1 deletion

‎deps/v8/AUTHORS‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -290,6 +290,7 @@ Stefan Penner <stefan.penner@gmail.com>
290290
Stefan Stojanovic <stefko.stojanovic@gmail.com>
291291
Stephan Hartmann <stha09@googlemail.com>
292292
Stephen Belanger <stephen.belanger@datadoghq.com>
293+
Steven R. Loomis <srl295@gmail.com>
293294
Sylvestre Ledru <sledru@mozilla.com>
294295
Takeshi Yoneda <takeshi@tetrate.io>
295296
Taketoshi Aono <brn@b6n.ch>

‎deps/v8/BUILD.gn‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1307,6 +1307,9 @@ config("features") {
13071307
if (v8_enable_temporal_support) {
13081308
defines += [ "V8_TEMPORAL_SUPPORT" ]
13091309
}
1310+
if (v8_enable_temporal_systemicu) {
1311+
defines += [ "V8_ENABLE_TEMPORAL_SYSTEMICU" ]
1312+
}
13101313
if (v8_enable_local_handle_zapping) {
13111314
defines += [ "ENABLE_LOCAL_HANDLE_ZAPPING" ]
13121315
}
@@ -3110,6 +3113,7 @@ generated_file("v8_generate_features_json") {
31103113
v8_enable_hugepage = v8_enable_hugepage
31113114
v8_enable_i18n_support = v8_enable_i18n_support
31123115
v8_enable_temporal_support = v8_enable_temporal_support
3116+
v8_enable_temporal_systemicu = v8_enable_temporal_systemicu
31133117
v8_enable_javascript_promise_hooks = v8_enable_javascript_promise_hooks
31143118
v8_enable_lite_mode = v8_enable_lite_mode
31153119
v8_enable_map_packing = v8_enable_map_packing

‎deps/v8/gni/v8.gni‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,10 @@ declare_args() {
6363
# Furthermore, some architectures don't have Rust toolchains in Chromium
6464
v8_enable_temporal_support = !(defined(build_with_node) && build_with_node)
6565

66+
# by default, don't enable compiling Temporal with a system ICU4C
67+
# (assume private headers are available)
68+
v8_enable_temporal_systemicu = false
69+
6670
# Use static libraries instead of source_sets.
6771
v8_static_library = false
6872

‎deps/v8/src/objects/js-temporal-zoneinfo64.cc‎

Lines changed: 44 additions & 4 deletions

0 commit comments

Comments
 (0)