crypto: remove redundant validateUint32 argument

tniessen · MylesBorins · commit c1cb639e8461 · 2019-12-17T17:06:47.000-05:00
The third parameter should be a boolean indicating whether the number must be positive. Passing zero works, but is unnecessary, misleading and inconsistent with other uses of the same function. PR-URL: #30579 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
diff --git a/lib/internal/crypto/pbkdf2.js b/lib/internal/crypto/pbkdf2.js
@@ -66,8 +66,8 @@ function check(password, salt, iterations, keylen, digest) {
 
   password = getArrayBufferView(password, 'password');
   salt = getArrayBufferView(salt, 'salt');
-  validateUint32(iterations, 'iterations', 0);
-  validateUint32(keylen, 'keylen', 0);
+  validateUint32(iterations, 'iterations');
+  validateUint32(keylen, 'keylen');
 
   return { password, salt, iterations, keylen, digest };
 }

Original file line number	Diff line number	Diff line change
`@@ -66,8 +66,8 @@ function check(password, salt, iterations, keylen, digest) {`
`66`	`66`
`67`	`67`	`password = getArrayBufferView(password, 'password');`
`68`	`68`	`salt = getArrayBufferView(salt, 'salt');`
`69`		`- validateUint32(iterations, 'iterations', 0);`
`70`		`- validateUint32(keylen, 'keylen', 0);`
	`69`	`+ validateUint32(iterations, 'iterations');`
	`70`	`+ validateUint32(keylen, 'keylen');`
`71`	`71`
`72`	`72`	`return { password, salt, iterations, keylen, digest };`
`73`	`73`	`}`