src: use starts_with instead of rfind/find

tniessen · aduh95 · commit c1aa9f49cdde · 2026-01-27T22:52:30.000+01:00
PR-URL: #61426 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: René <contact.9a5d6388@renegade334.me.uk> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
diff --git a/src/node_builtins.cc b/src/node_builtins.cc
@@ -158,7 +158,7 @@ BuiltinLoader::BuiltinCategories BuiltinLoader::GetBuiltinCategories() const {
       if (prefix.length() > id.length()) {
         continue;
       }
-      if (id.find(prefix) == 0 &&
+      if (id.starts_with(prefix) &&
           builtin_categories.can_be_required.count(id) == 0) {
         builtin_categories.cannot_be_required.emplace(id);
       }
diff --git a/src/path.cc b/src/path.cc
@@ -341,7 +341,7 @@ void FromNamespacedPath(std::string* path) {
 
 // Check if a path looks like an absolute path or file URL.
 bool IsAbsoluteFilePath(std::string_view path) {
-  if (path.rfind("file://", 0) == 0) {
+  if (path.starts_with("file://")) {
     return true;
   }
 #ifdef _WIN32
@@ -357,7 +357,7 @@ bool IsAbsoluteFilePath(std::string_view path) {
 std::string NormalizeFileURLOrPath(Environment* env, std::string_view path) {
   std::string normalized_string(path);
   constexpr std::string_view file_scheme = "file://";
-  if (normalized_string.rfind(file_scheme, 0) == 0) {
+  if (normalized_string.starts_with(file_scheme)) {
     auto out = ada::parse<ada::url_aggregator>(normalized_string);
     auto file_path = url::FileURLToPath(env, *out);
     if (!file_path.has_value()) {

Original file line number	Diff line number	Diff line change
`@@ -158,7 +158,7 @@ BuiltinLoader::BuiltinCategories BuiltinLoader::GetBuiltinCategories() const {`
`158`	`158`	`if (prefix.length() > id.length()) {`
`159`	`159`	`continue;`
`160`	`160`	`}`
`161`		`- if (id.find(prefix) == 0 &&`
	`161`	`+ if (id.starts_with(prefix) &&`
`162`	`162`	`builtin_categories.can_be_required.count(id) == 0) {`
`163`	`163`	`builtin_categories.cannot_be_required.emplace(id);`
`164`	`164`	`}`