deps: cherry-pick f4a2b7f3 from V8 upstream.

erinishimoticha · MylesBorins · commit c17ff6237689 · 2017-10-11T02:05:39.000-04:00
Original commit message: should ignore asyncTask* with null In V8Debugger code we don't expect task_id == null, e.g. asyncTaskStartedForStepping will trigger debug break on null as task_id. Let's filter task_id == null out. This issue is originally filed in Node.js: #15464 R=dgozman@chromium.org Bug: none Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: Icc9f96105b3c91ee1b102d545a7817f7ee93394c Reviewed-on: https://chromium-review.googlesource.com/695808 Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#48265} Fixes #15464 PR-URL: #16053 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
diff --git a/deps/v8/src/inspector/v8-inspector-impl.cc b/deps/v8/src/inspector/v8-inspector-impl.cc
@@ -286,18 +286,22 @@ std::unique_ptr<V8StackTrace> V8InspectorImpl::captureStackTrace(
 
 void V8InspectorImpl::asyncTaskScheduled(const StringView& taskName, void* task,
                                          bool recurring) {
+  if (!task) return;
   m_debugger->asyncTaskScheduled(taskName, task, recurring);
 }
 
 void V8InspectorImpl::asyncTaskCanceled(void* task) {
+  if (!task) return;
   m_debugger->asyncTaskCanceled(task);
 }
 
 void V8InspectorImpl::asyncTaskStarted(void* task) {
+  if (!task) return;
   m_debugger->asyncTaskStarted(task);
 }
 
 void V8InspectorImpl::asyncTaskFinished(void* task) {
+  if (!task) return;
   m_debugger->asyncTaskFinished(task);
 }
 

Original file line number	Diff line number	Diff line change
`@@ -286,18 +286,22 @@ std::unique_ptr<V8StackTrace> V8InspectorImpl::captureStackTrace(`
`286`	`286`
`287`	`287`	`void V8InspectorImpl::asyncTaskScheduled(const StringView& taskName, void* task,`
`288`	`288`	`bool recurring) {`
	`289`	`+ if (!task) return;`
`289`	`290`	`m_debugger->asyncTaskScheduled(taskName, task, recurring);`
`290`	`291`	`}`
`291`	`292`
`292`	`293`	`void V8InspectorImpl::asyncTaskCanceled(void* task) {`
	`294`	`+ if (!task) return;`
`293`	`295`	`m_debugger->asyncTaskCanceled(task);`
`294`	`296`	`}`
`295`	`297`
`296`	`298`	`void V8InspectorImpl::asyncTaskStarted(void* task) {`
	`299`	`+ if (!task) return;`
`297`	`300`	`m_debugger->asyncTaskStarted(task);`
`298`	`301`	`}`
`299`	`302`
`300`	`303`	`void V8InspectorImpl::asyncTaskFinished(void* task) {`
	`304`	`+ if (!task) return;`
`301`	`305`	`m_debugger->asyncTaskFinished(task);`
`302`	`306`	`}`
`303`	`307`