src: add nullptr handling from X509_STORE_new()

wooffie · marco-ippolito · commit c0fad18ac078 · 2025-03-06T13:38:17.000+01:00
In openssl we should check result of X509_STORE_new() for nullptr Refs: #56694 PR-URL: #56700 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
diff --git a/src/crypto/crypto_context.cc b/src/crypto/crypto_context.cc
@@ -219,6 +219,7 @@ X509_STORE* NewRootCertStore() {
   }
 
   X509_STORE* store = X509_STORE_new();
+  CHECK_NOT_NULL(store);
   if (*system_cert_path != '\0') {
     ERR_set_mark();
     X509_STORE_load_locations(store, system_cert_path, nullptr);

Original file line number	Diff line number	Diff line change
`@@ -219,6 +219,7 @@ X509_STORE* NewRootCertStore() {`
`219`	`219`	`}`
`220`	`220`
`221`	`221`	`X509_STORE* store = X509_STORE_new();`
	`222`	`+ CHECK_NOT_NULL(store);`
`222`	`223`	`if (*system_cert_path != '\0') {`
`223`	`224`	`ERR_set_mark();`
`224`	`225`	`X509_STORE_load_locations(store, system_cert_path, nullptr);`