test: add tests for invalid UTF-8

git-srinivas · danielleadams · commit c002930a6276 · 2022-01-31T22:53:49.000-05:00
Verify that `Blob.prototype.text()`, `streamConsumers.text()` and `TextDecoder.prototype.decode()` work as expected with invalid UTF-8. PR-URL: #40351 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com>
diff --git a/test/parallel/test-blob.js b/test/parallel/test-blob.js
@@ -87,6 +87,15 @@ assert.throws(() => new Blob({}), {
   }));
 }
 
+{
+  const b = new Blob(['hello', new Uint8Array([0xed, 0xa0, 0x88])]);
+  assert.strictEqual(b.size, 8);
+  b.text().then(common.mustCall((text) => {
+    assert.strictEqual(text, 'hello\ufffd\ufffd\ufffd');
+    assert.strictEqual(text.length, 8);
+  }));
+}
+
 {
   const b = new Blob(
     [
diff --git a/test/parallel/test-stream-consumers.js b/test/parallel/test-stream-consumers.js
@@ -13,6 +13,7 @@ const {
 } = require('stream/consumers');
 
 const {
+  Readable,
   PassThrough
 } = require('stream');
 
@@ -73,6 +74,19 @@ const kArrayBuffer =
   setTimeout(() => passthrough.end('there'), 10);
 }
 
+{
+  const readable = new Readable({
+    read() {}
+  });
+
+  text(readable).then((data) => {
+    assert.strictEqual(data, 'foo\ufffd\ufffd\ufffd');
+  });
+
+  readable.push(new Uint8Array([0x66, 0x6f, 0x6f, 0xed, 0xa0, 0x80]));
+  readable.push(null);
+}
+
 {
   const passthrough = new PassThrough();
 
diff --git a/test/parallel/test-whatwg-encoding-custom-textdecoder.js b/test/parallel/test-whatwg-encoding-custom-textdecoder.js
@@ -191,3 +191,11 @@ if (common.hasIntl) {
     }
   );
 }
+
+// Test TextDecoder for incomplete UTF-8 byte sequence.
+{
+  const decoder = new TextDecoder();
+  const chunk = new Uint8Array([0x66, 0x6f, 0x6f, 0xed]);
+  const str = decoder.decode(chunk);
+  assert.strictEqual(str, 'foo\ufffd');
+}

Original file line number	Diff line number	Diff line change
`@@ -87,6 +87,15 @@ assert.throws(() => new Blob({}), {`
`87`	`87`	`}));`
`88`	`88`	`}`
`89`	`89`
	`90`	`+{`
	`91`	`+ const b = new Blob(['hello', new Uint8Array([0xed, 0xa0, 0x88])]);`
	`92`	`+ assert.strictEqual(b.size, 8);`
	`93`	`+ b.text().then(common.mustCall((text) => {`
	`94`	`+ assert.strictEqual(text, 'hello\ufffd\ufffd\ufffd');`
	`95`	`+ assert.strictEqual(text.length, 8);`
	`96`	`+ }));`
	`97`	`+}`
	`98`	`+`
`90`	`99`	`{`
`91`	`100`	`const b = new Blob(`
`92`	`101`	`[`
Original file line number	Diff line number	Diff line change
`@@ -191,3 +191,11 @@ if (common.hasIntl) {`
`191`	`191`	`}`
`192`	`192`	`);`
`193`	`193`	`}`
	`194`	`+`
	`195`	`+// Test TextDecoder for incomplete UTF-8 byte sequence.`
	`196`	`+{`
	`197`	`+ const decoder = new TextDecoder();`
	`198`	`+ const chunk = new Uint8Array([0x66, 0x6f, 0x6f, 0xed]);`
	`199`	`+ const str = decoder.decode(chunk);`
	`200`	`+ assert.strictEqual(str, 'foo\ufffd');`
	`201`	`+}`