test: skip in test-buffer-tostring-rangeerror on allocation failure

joyeecheung · marco-ippolito · commit bffd4ec37905 · 2025-06-05T08:14:58.000+02:00
If the buffer allocation fails due to insufficient memory, there is no point continue testing toString(). PR-URL: #58415 Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
diff --git a/test/parallel/test-buffer-tostring-rangeerror.js b/test/parallel/test-buffer-tostring-rangeerror.js
@@ -18,8 +18,22 @@ const message = {
   code: 'ERR_STRING_TOO_LONG',
   name: 'Error',
 };
-assert.throws(() => Buffer(len).toString('utf8'), message);
-assert.throws(() => SlowBuffer(len).toString('utf8'), message);
-assert.throws(() => Buffer.alloc(len).toString('utf8'), message);
-assert.throws(() => Buffer.allocUnsafe(len).toString('utf8'), message);
-assert.throws(() => Buffer.allocUnsafeSlow(len).toString('utf8'), message);
+
+function test(getBuffer) {
+  let buf;
+  try {
+    buf = getBuffer();
+  } catch (e) {
+    // If the buffer allocation fails, we skip the test.
+    if (e.code === 'ERR_MEMORY_ALLOCATION_FAILED' || /Array buffer allocation failed/.test(e.message)) {
+      return;
+    }
+  }
+  assert.throws(() => { buf.toString('utf8'); }, message);
+}
+
+test(() => Buffer(len));
+test(() => SlowBuffer(len));
+test(() => Buffer.alloc(len));
+test(() => Buffer.allocUnsafe(len));
+test(() => Buffer.allocUnsafeSlow(len));
