crypto: improve randomInt out-of-range error message

Trott · addaleax · commit bf5a85b43a80 · 2020-09-22T23:48:12.000+02:00
Previously, the crypto.randomInt() message when "max" was less than or equal to "min" made it sound like the lower bound for "max" was hard-coded. Make it clear that it is instead dynamic based on the value of "min". For crypto.randomInt(10,0): Before: RangeError [ERR_OUT_OF_RANGE]: The value of "max" is out of range. It must be > 10. Received 0 After: RangeError [ERR_OUT_OF_RANGE]: The value of "max" is out of range. It must be greater than the value of "min" (10). Received 0 PR-URL: #35088 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
diff --git a/lib/internal/crypto/random.js b/lib/internal/crypto/random.js
@@ -150,7 +150,9 @@ function randomInt(min, max, callback) {
     throw new ERR_INVALID_ARG_TYPE('max', 'safe integer', max);
   }
   if (max <= min) {
-    throw new ERR_OUT_OF_RANGE('max', `> ${min}`, max);
+    throw new ERR_OUT_OF_RANGE(
+      'max', `greater than the value of "min" (${min})`, max
+    );
   }
 
   // First we generate a random int between [0..range)
diff --git a/test/parallel/test-crypto-random.js b/test/parallel/test-crypto-random.js
@@ -462,8 +462,9 @@ assert.throws(
     assert.throws(() => crypto.randomInt(...arg, common.mustNotCall()), {
       code: 'ERR_OUT_OF_RANGE',
       name: 'RangeError',
-      message: 'The value of "max" is out of range. It must be > ' +
-               `${arg[arg.length - 2] || 0}. Received ${arg[arg.length - 1]}`
+      message: 'The value of "max" is out of range. It must be greater than ' +
+      `the value of "min" (${arg[arg.length - 2] || 0}). ` +
+      `Received ${arg[arg.length - 1]}`
     });
   }
 

Original file line number	Diff line number	Diff line change
`@@ -150,7 +150,9 @@ function randomInt(min, max, callback) {`
`150`	`150`	`throw new ERR_INVALID_ARG_TYPE('max', 'safe integer', max);`
`151`	`151`	`}`
`152`	`152`	`if (max <= min) {`
`153`		- throw new ERR_OUT_OF_RANGE('max', `> ${min}`, max);
	`153`	`+ throw new ERR_OUT_OF_RANGE(`
	`154`	+ 'max', `greater than the value of "min" (${min})`, max
	`155`	`+ );`
`154`	`156`	`}`
`155`	`157`
`156`	`158`	`// First we generate a random int between [0..range)`