test: account for truthy signal in flaky async_hooks tests

RaisinTen · targos · commit bef67e45e36a · 2025-05-31T13:31:47.000+02:00
When the spawned child process gets closed with a signal, the exit code is not set and that is why the exit code assertion was failing. This change adjusts the test to check the signal and if it is truthy, it doesn't assert the exit code and instead logs the signal and continues the rest of the assertions. Refs: #58463 (comment) Refs: #58199 Refs: #58463 Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #58478 Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
diff --git a/test/async-hooks/test-emit-after-on-destroyed.js b/test/async-hooks/test-emit-after-on-destroyed.js
@@ -52,8 +52,12 @@ if (process.argv[2] === 'child') {
   child.stderr.on('data', (d) => { errData = Buffer.concat([ errData, d ]); });
   child.stdout.on('data', (d) => { outData = Buffer.concat([ outData, d ]); });
 
-  child.on('close', common.mustCall((code) => {
-    assert.strictEqual(code, 1);
+  child.on('close', common.mustCall((code, signal) => {
+    if (signal) {
+      console.log(`Child closed with signal: ${signal}`);
+    } else {
+      assert.strictEqual(code, 1);
+    }
     assert.match(outData.toString(), heartbeatMsg,
                  'did not crash until we reached offending line of code ' +
                  `(found ${outData})`);
diff --git a/test/async-hooks/test-improper-unwind.js b/test/async-hooks/test-improper-unwind.js
@@ -55,8 +55,12 @@ if (process.argv[2] === 'child') {
   child.stderr.on('data', (d) => { errData = Buffer.concat([ errData, d ]); });
   child.stdout.on('data', (d) => { outData = Buffer.concat([ outData, d ]); });
 
-  child.on('close', common.mustCall((code) => {
-    assert.strictEqual(code, 1);
+  child.on('close', common.mustCall((code, signal) => {
+    if (signal) {
+      console.log(`Child closed with signal: ${signal}`);
+    } else {
+      assert.strictEqual(code, 1);
+    }
     assert.match(outData.toString(), heartbeatMsg,
                  'did not crash until we reached offending line of code ' +
                  `(found ${outData})`);
