test_runner: use paths for test locations

cjihrig · marco-ippolito · commit be587e3ae30e · 2024-05-17T16:27:10.000+02:00
This commit transforms test locations to paths when V8 provides file URLs (which seems to be for ESM files). Fixes: #51610 PR-URL: #52010 Backport-PR-URL: #52872 Fixes: #51392 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
diff --git a/lib/internal/test_runner/test.js b/lib/internal/test_runner/test.js
@@ -15,6 +15,7 @@ const {
   PromisePrototypeThen,
   PromiseResolve,
   SafePromisePrototypeFinally,
+  StringPrototypeStartsWith,
   ReflectApply,
   RegExpPrototypeExec,
   SafeMap,
@@ -58,6 +59,7 @@ const {
 } = require('internal/validators');
 const { setTimeout } = require('timers');
 const { TIMEOUT_MAX } = require('internal/timers');
+const { fileURLToPath } = require('internal/url');
 const { availableParallelism } = require('os');
 const { bigint: hrtime } = process.hrtime;
 const kCallbackAndPromisePresent = 'callbackAndPromisePresent';
@@ -385,6 +387,10 @@ class Test extends AsyncResource {
           this.loc.file = entry.originalSource;
         }
       }
+
+      if (StringPrototypeStartsWith(this.loc.file, 'file://')) {
+        this.loc.file = fileURLToPath(this.loc.file);
+      }
     }
   }
 
diff --git a/test/fixtures/test-runner/output/source_mapped_locations.snapshot b/test/fixtures/test-runner/output/source_mapped_locations.snapshot
@@ -3,7 +3,7 @@ TAP version 13
 not ok 1 - fails
   ---
   duration_ms: *
-  location: 'file:///test/fixtures/test-runner/output/source_mapped_locations.ts:5:1'
+  location: '/test/fixtures/test-runner/output/source_mapped_locations.ts:5:1'
   failureType: 'testCodeFailure'
   error: |-
     Expected values to be strictly equal:

Original file line number	Diff line number	Diff line change
`@@ -15,6 +15,7 @@ const {`
`15`	`15`	`PromisePrototypeThen,`
`16`	`16`	`PromiseResolve,`
`17`	`17`	`SafePromisePrototypeFinally,`
	`18`	`+ StringPrototypeStartsWith,`
`18`	`19`	`ReflectApply,`
`19`	`20`	`RegExpPrototypeExec,`
`20`	`21`	`SafeMap,`
`@@ -58,6 +59,7 @@ const {`
`58`	`59`	`} = require('internal/validators');`
`59`	`60`	`const { setTimeout } = require('timers');`
`60`	`61`	`const { TIMEOUT_MAX } = require('internal/timers');`
	`62`	`+const { fileURLToPath } = require('internal/url');`
`61`	`63`	`const { availableParallelism } = require('os');`
`62`	`64`	`const { bigint: hrtime } = process.hrtime;`
`63`	`65`	`const kCallbackAndPromisePresent = 'callbackAndPromisePresent';`
`@@ -385,6 +387,10 @@ class Test extends AsyncResource {`
`385`	`387`	`this.loc.file = entry.originalSource;`
`386`	`388`	`}`
`387`	`389`	`}`
	`390`	`+`
	`391`	`+ if (StringPrototypeStartsWith(this.loc.file, 'file://')) {`
	`392`	`+ this.loc.file = fileURLToPath(this.loc.file);`
	`393`	`+ }`
`388`	`394`	`}`
`389`	`395`	`}`
`390`	`396`