test: use InitializeNodeWithArgs in cctest

addaleax · addaleax · commit bdf6d41c7274 · 2020-09-23T20:07:55.000+02:00
Refs: d7f1107 Fixes: #30257 Backport-PR-URL: #35241 PR-URL: #32406 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
diff --git a/test/cctest/node_test_fixture.h b/test/cctest/node_test_fixture.h
@@ -73,11 +73,13 @@ class NodeTestFixture : public ::testing::Test {
     if (!node_initialized) {
       uv_os_unsetenv("NODE_OPTIONS");
       node_initialized = true;
-      int argc = 1;
-      const char* argv0 = "cctest";
-      int exec_argc;
-      const char** exec_argv;
-      node::Init(&argc, &argv0, &exec_argc, &exec_argv);
+      std::vector<std::string> argv { "cctest" };
+      std::vector<std::string> exec_argv;
+      std::vector<std::string> errors;
+
+      int exitcode = node::InitializeNodeWithArgs(&argv, &exec_argv, &errors);
+      CHECK_EQ(exitcode, 0);
+      CHECK(errors.empty());
     }
 
     tracing_agent = std::make_unique<node::tracing::Agent>();
