http2: fix memory leak for uncommon headers

addaleax · targos · commit bcaf59c73948 · 2018-06-19T08:59:42.000+02:00
Fix a memory leak that occurs with header names that are short and not present in the static table of default headers. PR-URL: #21336 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
diff --git a/src/node_http2.h b/src/node_http2.h
@@ -1203,6 +1203,7 @@ class ExternalHeader :
     }
 
     if (may_internalize && vec.len < 64) {
+      nghttp2_rcbuf_decref(buf);
       // This is a short header name, so there is a good chance V8 already has
       // it internalized.
       return GetInternalizedString(env, vec);

Original file line number	Diff line number	Diff line change
`@@ -1203,6 +1203,7 @@ class ExternalHeader :`
`1203`	`1203`	`}`
`1204`	`1204`
`1205`	`1205`	`if (may_internalize && vec.len < 64) {`
	`1206`	`+ nghttp2_rcbuf_decref(buf);`
`1206`	`1207`	`// This is a short header name, so there is a good chance V8 already has`
`1207`	`1208`	`// it internalized.`
`1208`	`1209`	`return GetInternalizedString(env, vec);`