src: fix SplitString to ignore white spaces

himself65 · BridgeAR · commit bc09d2f83d1f · 2019-03-14T17:15:30.000+01:00
PR-URL: #26545 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Khaidi Chu <i@2333.moe>
diff --git a/src/util.cc b/src/util.cc
@@ -134,6 +134,7 @@ std::vector<std::string> SplitString(const std::string& in, char delim) {
   while (in_stream.good()) {
     std::string item;
     std::getline(in_stream, item, delim);
+    if (item.empty()) continue;
     out.emplace_back(std::move(item));
   }
   return out;
diff --git a/test/parallel/test-cli-node-options.js b/test/parallel/test-cli-node-options.js
@@ -14,6 +14,8 @@ tmpdir.refresh();
 const printA = require.resolve('../fixtures/printA.js');
 expect(`-r ${printA}`, 'A\nB\n');
 expect(`-r ${printA} -r ${printA}`, 'A\nB\n');
+expect(`   -r ${printA}    -r ${printA}`, 'A\nB\n');
+expect(`   --require ${printA}    --require ${printA}`, 'A\nB\n');
 expect('--no-deprecation', 'B\n');
 expect('--no-warnings', 'B\n');
 expect('--no_warnings', 'B\n');

Original file line number	Diff line number	Diff line change
`@@ -134,6 +134,7 @@ std::vector<std::string> SplitString(const std::string& in, char delim) {`
`134`	`134`	`while (in_stream.good()) {`
`135`	`135`	`std::string item;`
`136`	`136`	`std::getline(in_stream, item, delim);`
	`137`	`+ if (item.empty()) continue;`
`137`	`138`	`out.emplace_back(std::move(item));`
`138`	`139`	`}`
`139`	`140`	`return out;`