src: remove base64 from process.versions

richardlau · marco-ippolito · commit bb57e909aa9f · 2025-03-06T13:38:00.000+01:00
The `base64` dependency was previously removed along with the update script (`tools/dep_updaters/update-base64.sh`) but the generated header, `src/base64_version.h` was left behind and `process.versions` was still listing the last version of `base64` that was included in Node.js before it was removed Refs: #52714 PR-URL: #53442 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
diff --git a/src/base64_version.h b/src/base64_version.h
diff --git a/src/node_metadata.cc b/src/node_metadata.cc
@@ -2,7 +2,6 @@
 #include "acorn_version.h"
 #include "ada.h"
 #include "ares.h"
-#include "base64_version.h"
 #include "brotli/encode.h"
 #include "cjs_module_lexer_version.h"
 #include "llhttp.h"
@@ -121,7 +120,6 @@ Metadata::Versions::Versions() {
 
   acorn = ACORN_VERSION;
   cjs_module_lexer = CJS_MODULE_LEXER_VERSION;
-  base64 = BASE64_VERSION;
   uvwasi = UVWASI_VERSION_STRING;
 
 #if HAVE_OPENSSL
diff --git a/src/node_metadata.h b/src/node_metadata.h
@@ -49,8 +49,7 @@ namespace node {
   V(simdutf)                                                                   \
   V(ada)                                                                       \
   NODE_VERSIONS_KEY_UNDICI(V)                                                  \
-  V(cjs_module_lexer)                                                          \
-  V(base64)
+  V(cjs_module_lexer)
 
 #if HAVE_OPENSSL
 #define NODE_VERSIONS_KEY_CRYPTO(V) V(openssl)
diff --git a/test/parallel/test-process-versions.js b/test/parallel/test-process-versions.js
@@ -21,7 +21,6 @@ const expected_keys = [
   'simdutf',
   'ada',
   'cjs_module_lexer',
-  'base64',
 ];
 
 const hasUndici = process.config.variables.node_builtin_shareable_builtins.includes('deps/undici/undici.js');
