sqlite: always copy changeset before applying · nodejs/node@baf112b · GitHub
Skip to content

Commit baf112b

Browse files
trivikraduh95
authored andcommitted
sqlite: always copy changeset before applying
SQLite can invoke JavaScript through user-defined SQL functions while applying a changeset, even when no filter or conflict callback is set. Copy non-empty changesets unconditionally so JavaScript cannot detach or modify the input while SQLite is still reading it. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: codex PR-URL: #65870 Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 678ff35 commit baf112b

2 files changed

Lines changed: 40 additions & 5 deletions

File tree

‎src/node_sqlite.cc‎

Lines changed: 4 additions & 5 deletions

‎test/parallel/test-sqlite-session.js‎

Lines changed: 36 additions & 0 deletions

0 commit comments

Comments
 (0)