fs: extract kWriteFileMaxChunkSize constant

rickyes · BethGriggs · commit baa823172842 · 2020-04-27T20:40:43.000+01:00
PR-URL: #32640 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>
diff --git a/lib/internal/fs/promises.js b/lib/internal/fs/promises.js
@@ -4,6 +4,11 @@
 // See https://github.com/libuv/libuv/pull/1501.
 const kIoMaxLength = 2 ** 31 - 1;
 
+// Note: This is different from kReadFileBufferLength used for non-promisified
+// fs.readFile.
+const kReadFileMaxChunkSize = 2 ** 14;
+const kWriteFileMaxChunkSize = 2 ** 14;
+
 const {
   MathMax,
   MathMin,
@@ -150,16 +155,12 @@ async function writeFileHandle(filehandle, data) {
   do {
     const { bytesWritten } =
       await write(filehandle, data, 0,
-                  MathMin(16384, data.length));
+                  MathMin(kWriteFileMaxChunkSize, data.length));
     remaining -= bytesWritten;
     data = data.slice(bytesWritten);
   } while (remaining > 0);
 }
 
-// Note: This is different from kReadFileBufferLength used for non-promisified
-// fs.readFile.
-const kReadFileMaxChunkSize = 16384;
-
 async function readFileHandle(filehandle, options) {
   const statFields = await binding.fstat(filehandle.fd, false, kUsePromises);
 
