test: don't skip when common.mustCall() is pending

cjihrig · jasnell · commit ba96c8f23e50 · 2017-09-20T09:32:46.000-07:00
The test parallel/test-dgram-multicast-set-interface.js was calling common.skip() on hosts that do not support IPv6. However, by this point, there were several outstanding common.mustCall() invocations. The process.exit() in common.skip() triggered those common.mustCall()s as errors. Fixes: #15419 PR-URL: #15421 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
diff --git a/test/parallel/test-dgram-multicast-set-interface.js b/test/parallel/test-dgram-multicast-set-interface.js
@@ -72,10 +72,11 @@ const dgram = require('dgram');
   }));
 }
 
-if (!common.hasIPv6) {
-  common.skip('Skipping udp6 tests, no IPv6 support.');
+// If IPv6 is not supported, skip the rest of the test. However, don't call
+// common.skip(), which calls process.exit() while there is outstanding
+// common.mustCall() activity.
+if (!common.hasIPv6)
   return;
-}
 
 {
   const socket = dgram.createSocket('udp6');

Original file line number	Diff line number	Diff line change
`@@ -72,10 +72,11 @@ const dgram = require('dgram');`
`72`	`72`	`}));`
`73`	`73`	`}`
`74`	`74`
`75`		`-if (!common.hasIPv6) {`
`76`		`- common.skip('Skipping udp6 tests, no IPv6 support.');`
	`75`	`+// If IPv6 is not supported, skip the rest of the test. However, don't call`
	`76`	`+// common.skip(), which calls process.exit() while there is outstanding`
	`77`	`+// common.mustCall() activity.`
	`78`	`+if (!common.hasIPv6)`
`77`	`79`	`return;`
`78`		`-}`
`79`	`80`
`80`	`81`	`{`
`81`	`82`	`const socket = dgram.createSocket('udp6');`