buffer: increase coverage by removing dead code

decareano · MylesBorins · commit b9e1f603336b · 2017-09-12T03:18:22.000+02:00
buffer.js:L196 `if (value == null)` guarantees `obj != null` so L406+L418 are unnecessary. PR-URL: #15100 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
diff --git a/lib/buffer.js b/lib/buffer.js
@@ -374,17 +374,15 @@ function fromObject(obj) {
     return b;
   }
 
-  if (obj != null) {
-    if (obj.length !== undefined || isAnyArrayBuffer(obj.buffer)) {
-      if (typeof obj.length !== 'number' || obj.length !== obj.length) {
-        return new FastBuffer();
-      }
-      return fromArrayLike(obj);
+  if (obj.length !== undefined || isAnyArrayBuffer(obj.buffer)) {
+    if (typeof obj.length !== 'number' || obj.length !== obj.length) {
+      return new FastBuffer();
     }
+    return fromArrayLike(obj);
+  }
 
-    if (obj.type === 'Buffer' && Array.isArray(obj.data)) {
-      return fromArrayLike(obj.data);
-    }
+  if (obj.type === 'Buffer' && Array.isArray(obj.data)) {
+    return fromArrayLike(obj.data);
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -374,17 +374,15 @@ function fromObject(obj) {`
`374`	`374`	`return b;`
`375`	`375`	`}`
`376`	`376`
`377`		`- if (obj != null) {`
`378`		`- if (obj.length !== undefined \|\| isAnyArrayBuffer(obj.buffer)) {`
`379`		`- if (typeof obj.length !== 'number' \|\| obj.length !== obj.length) {`
`380`		`- return new FastBuffer();`
`381`		`- }`
`382`		`- return fromArrayLike(obj);`
	`377`	`+ if (obj.length !== undefined \|\| isAnyArrayBuffer(obj.buffer)) {`
	`378`	`+ if (typeof obj.length !== 'number' \|\| obj.length !== obj.length) {`
	`379`	`+ return new FastBuffer();`
`383`	`380`	`}`
	`381`	`+ return fromArrayLike(obj);`
	`382`	`+ }`
`384`	`383`
`385`		`- if (obj.type === 'Buffer' && Array.isArray(obj.data)) {`
`386`		`- return fromArrayLike(obj.data);`
`387`		`- }`
	`384`	`+ if (obj.type === 'Buffer' && Array.isArray(obj.data)) {`
	`385`	`+ return fromArrayLike(obj.data);`
`388`	`386`	`}`
`389`	`387`	`}`
`390`	`388`