test,fs: delay unlink in test-regress-GH-4027.js

jaimecbernardo · addaleax · commit b9e07f9fec17 · 2017-07-18T19:57:54.000+02:00
The sequential/test-regress-GH-4027 test is flaky with an increased system load, failing when the watched file is unlinked before the first state of the watched file is retrieved. After increasing the delay before unlinking and calling setTimeout after watchFile, the flakiness stopped reproducing. PR-URL: #14010 Fixes: #13800 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
diff --git a/test/sequential/test-regress-GH-4027.js b/test/sequential/test-regress-GH-4027.js
@@ -29,10 +29,11 @@ common.refreshTmpDir();
 
 const filename = path.join(common.tmpDir, 'watched');
 fs.writeFileSync(filename, 'quis custodiet ipsos custodes');
-setTimeout(fs.unlinkSync, 100, filename);
 
 fs.watchFile(filename, { interval: 50 }, common.mustCall(function(curr, prev) {
   assert.strictEqual(prev.nlink, 1);
   assert.strictEqual(curr.nlink, 0);
   fs.unwatchFile(filename);
 }));
+
+setTimeout(fs.unlinkSync, common.platformTimeout(300), filename);
