src: fix off-by-one error in native SetImmediate

addaleax · BridgeAR · commit b9d21e5bfd7e · 2019-06-17T21:12:29.000+02:00
Previously, the throwing callback would have been re-executed in case of an exception. This patch corrects the calculation to exclude the callback. PR-URL: #28082 Fixes: #26754 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: James M Snell <jasnell@gmail.com>
diff --git a/src/env.cc b/src/env.cc
@@ -641,6 +641,11 @@ void Environment::RunAndClearNativeImmediates() {
           if (!try_catch.HasTerminated())
             FatalException(isolate(), try_catch);
 
+          // We are done with the current callback. Increase the counter so that
+          // the steps below make everything *after* the current item part of
+          // the new list.
+          it++;
+
           // Bail out, remove the already executed callbacks from list
           // and set up a new TryCatch for the other pending callbacks.
           std::move_backward(it, list.end(), list.begin() + (list.end() - it));
