test: refactor test-fs-non-number-arguments-throw

targos · MylesBorins · commit b98813d97cc4 · 2016-12-21T14:33:59.000-05:00
* Add RegExp arguments to throws assertions. * Use common.mustCall for emitter callback. PR-URL: #9844 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
diff --git a/test/parallel/test-fs-non-number-arguments-throw.js b/test/parallel/test-fs-non-number-arguments-throw.js
@@ -15,17 +15,20 @@ const saneEmitter = fs.createReadStream(tempFile, { start: 4, end: 6 });
 
 assert.throws(function() {
   fs.createReadStream(tempFile, { start: '4', end: 6 });
-}, "start as string didn't throw an error for createReadStream");
+}, /^TypeError: start must be a Number$/,
+   "start as string didn't throw an error for createReadStream");
 
 assert.throws(function() {
   fs.createReadStream(tempFile, { start: 4, end: '6' });
-}, "end as string didn't throw an error");
+}, /^TypeError: end must be a Number$/,
+   "end as string didn't throw an error for createReadStream");
 
 assert.throws(function() {
   fs.createWriteStream(tempFile, { start: '4' });
-}, "start as string didn't throw an error for createWriteStream");
+}, /^TypeError: start must be a Number$/,
+   "start as string didn't throw an error for createWriteStream");
 
-saneEmitter.on('data', function(data) {
+saneEmitter.on('data', common.mustCall(function(data) {
   assert.strictEqual(sanity, data.toString('utf8'), 'read ' +
                      data.toString('utf8') + ' instead of ' + sanity);
-});
+}));
