ffi: support SharedArrayBuffer in getRawPointer · nodejs/node@b98294b · GitHub
Skip to content

Commit b98294b

Browse files
ganjanggejangaduh95
authored andcommitted
ffi: support SharedArrayBuffer in getRawPointer
Signed-off-by: Junsoo Ha <junsoo2018@naver.com> PR-URL: #64864 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
1 parent 312f0c6 commit b98294b

3 files changed

Lines changed: 14 additions & 5 deletions

File tree

doc/api/ffi.md

Lines changed: 1 addition & 1 deletion

src/ffi/data.cc

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -739,7 +739,8 @@ void GetRawPointer(const FunctionCallbackInfo<Value>& args) {
739739
if (args.Length() < 1) {
740740
THROW_ERR_INVALID_ARG_TYPE(
741741
env,
742-
"The first argument must be a Buffer, ArrayBuffer, or ArrayBufferView");
742+
"The first argument must be a Buffer, ArrayBuffer, SharedArrayBuffer, "
743+
"or ArrayBufferView");
743744
return;
744745
}
745746

@@ -758,9 +759,10 @@ void GetRawPointer(const FunctionCallbackInfo<Value>& args) {
758759
store = args[0].As<ArrayBufferView>()->Buffer()->GetBackingStore();
759760
offset = args[0].As<ArrayBufferView>()->ByteOffset();
760761
} else {
761-
THROW_ERR_INVALID_ARG_TYPE(env,
762-
"The first argument must be a Buffer, "
763-
"ArrayBuffer, or ArrayBufferView");
762+
THROW_ERR_INVALID_ARG_TYPE(
763+
env,
764+
"The first argument must be a Buffer, "
765+
"ArrayBuffer, SharedArrayBuffer, or ArrayBufferView");
764766
return;
765767
}
766768

test/ffi/test-ffi-memory.js

Lines changed: 7 additions & 0 deletions

0 commit comments

Comments
 (0)