benchmark: improve cli error message

mscdex · evanlucas · commit b7aeed7a7e92 · 2017-05-02T12:46:11.000-05:00
When no matching benchmark files are found, a more sensible error is shown now. PR-URL: #12421 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
diff --git a/benchmark/_cli.js b/benchmark/_cli.js
@@ -88,6 +88,8 @@ CLI.prototype.benchmarks = function() {
   const filter = this.optional.filter || false;
 
   for (const category of this.items) {
+    if (benchmarks[category] === undefined)
+      continue;
     for (const scripts of benchmarks[category]) {
       if (filter && scripts.lastIndexOf(filter) === -1) continue;
 
diff --git a/benchmark/compare.js b/benchmark/compare.js
@@ -35,7 +35,7 @@ const runs = cli.optional.runs ? parseInt(cli.optional.runs, 10) : 30;
 const benchmarks = cli.benchmarks();
 
 if (benchmarks.length === 0) {
-  console.error('no benchmarks found');
+  console.error('No benchmarks found');
   process.exitCode = 1;
   return;
 }

Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,7 @@ const runs = cli.optional.runs ? parseInt(cli.optional.runs, 10) : 30;`
`35`	`35`	`const benchmarks = cli.benchmarks();`
`36`	`36`
`37`	`37`	`if (benchmarks.length === 0) {`
`38`		`- console.error('no benchmarks found');`
	`38`	`+ console.error('No benchmarks found');`
`39`	`39`	`process.exitCode = 1;`
`40`	`40`	`return;`
`41`	`41`	`}`