test: add test-fs-writeFileSync-invalid-windows

Trott · targos · commit b4643dd9dcf6 · 2019-07-20T11:05:25.000+02:00
Add a known_issues test for the Windows returning ENOTFOUND where EINVAL is more appropriate. This happens with various functions in the `fs` module when an invalid path is used. Refs: #8987 PR-URL: #28569 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
diff --git a/test/known_issues/test-fs-writeFileSync-invalid-windows.js b/test/known_issues/test-fs-writeFileSync-invalid-windows.js
@@ -0,0 +1,21 @@
+'use strict';
+
+const common = require('../common');
+
+// Test that using an invalid file name with writeFileSync() on Windows returns
+// EINVAL. With libuv 1.x, it returns ENOTFOUND. This should be fixed when we
+// update to libuv 2.x.
+//
+// Refs: https://github.com/nodejs/node/issues/8987
+
+const assert = require('assert');
+const fs = require('fs');
+
+if (!common.isWindows) {
+  // Change to `common.skip()` when the test is moved out of `known_issues`.
+  assert.fail('Windows-only test');
+}
+
+assert.throws(() => {
+  fs.writeFileSync('fhqwhgads??', 'come on');
+}, { code: 'EINVAL' });
