doc: standardizing on make -j4 · nodejs/node@b44e789 · GitHub
Skip to content

Commit b44e789

Browse files
Jonathan DarlingFishrock123
authored andcommitted
doc: standardizing on make -j4
Standardizes docs to use -j4 instead of -j8 as it appears to be the most inclusive recommendation based on discussion in #9961. PR-URL: #9961 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
1 parent ff8fdb1 commit b44e789

4 files changed

Lines changed: 5 additions & 5 deletions

File tree

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 1 addition & 1 deletion

CONTRIBUTING.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,7 @@ to see how they should be structured can also help.
156156
To run the tests on Unix / OS X:
157157

158158
```text
159-
$ ./configure && make -j8 test
159+
$ ./configure && make -j4 test
160160
```
161161

162162
Windows:
@@ -189,7 +189,7 @@ You can run tests directly with node:
189189
$ ./node ./test/parallel/test-stream2-transform.js
190190
```
191191

192-
Remember to recompile with `make -j8` in between test runs if you change
192+
Remember to recompile with `make -j4` in between test runs if you change
193193
core modules.
194194

195195
### Step 6: Push

doc/guides/building-node-with-ninja.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ ninja: Entering directory `out/Release`
1616

1717
The bottom line will change while building, showing the progress as `[finished/total]` build steps.
1818
This is useful output that `make` does not produce and is one of the benefits of using Ninja.
19-
Also, Ninja will likely compile much faster than even `make -j8` (or `-j<number of processor threads on your machine>`).
19+
Also, Ninja will likely compile much faster than even `make -j4` (or `-j<number of processor threads on your machine>`).
2020

2121
## Considerations
2222

doc/onboarding-extras.md

Lines changed: 1 addition & 1 deletion

0 commit comments

Comments
 (0)