zlib: reject invalid zstd dictionaries · nodejs/node@b44c072 · GitHub
Skip to content

Commit b44c072

Browse files
jasnelladuh95
authored andcommitted
zlib: reject invalid zstd dictionaries
Signed-off-by: James M Snell <jsnell@cloudflare.com> PR-URL: #65867 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com>
1 parent 2e1772a commit b44c072

3 files changed

Lines changed: 27 additions & 3 deletions

File tree

‎lib/zlib.js‎

Lines changed: 5 additions & 1 deletion

‎src/node_zlib.cc‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1820,8 +1820,7 @@ CompressionError ZstdDecompressContext::Init(uint64_t pledged_src_size,
18201820
}
18211821

18221822
CompressionError ZstdDecompressContext::ResetStream() {
1823-
const size_t result =
1824-
ZSTD_DCtx_reset(dctx_.get(), ZSTD_reset_session_only);
1823+
const size_t result = ZSTD_DCtx_reset(dctx_.get(), ZSTD_reset_session_only);
18251824
if (ZSTD_isError(result)) {
18261825
const ZSTD_ErrorCode error = ZSTD_getErrorCode(result);
18271826
return CompressionError(

‎test/parallel/test-zlib-zstd-dictionary.js‎

Lines changed: 21 additions & 0 deletions

0 commit comments

Comments
 (0)