process: fix wrong asyncContext under unhandled-rejections=strict

islandryu · targos · commit b3295b83536d · 2025-10-06T16:26:12.000+02:00
Fixes: #60034 PR-URL: #60103 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
diff --git a/lib/internal/process/promises.js b/lib/internal/process/promises.js
@@ -343,7 +343,7 @@ function strictUnhandledRejectionsMode(promise, promiseInfo, promiseAsyncId) {
     reason : new UnhandledPromiseRejection(reason);
   // This destroys the async stack, don't clear it after
   triggerUncaughtException(err, true /* fromPromise */);
-  if (promiseAsyncId === undefined) {
+  if (promiseAsyncId !== undefined) {
     pushAsyncContext(
       promise[kAsyncIdSymbol],
       promise[kTriggerAsyncIdSymbol],
diff --git a/test/parallel/test-promise-unhandled-error-with-reading-file.js b/test/parallel/test-promise-unhandled-error-with-reading-file.js
@@ -0,0 +1,29 @@
+// Flags: --unhandled-rejections=strict
+'use strict';
+
+const common = require('../common');
+const fs = require('fs');
+const assert = require('assert');
+
+process.on('unhandledRejection', common.mustNotCall);
+
+process.on('uncaughtException', common.mustCall((err) => {
+  assert.ok(err.message.includes('foo'));
+}));
+
+
+async function readFile() {
+  return fs.promises.readFile(__filename);
+}
+
+async function crash() {
+  throw new Error('foo');
+}
+
+
+async function main() {
+  crash();
+  readFile();
+}
+
+main();
