src: add check for Bignum in GroupOrderSize

wooffie · targos · commit b240ca67b9ac · 2025-02-02T17:37:00.000+01:00
I think it's missed, cause in this file we have example of checking result of BignumPointer::new Refs: #56692 PR-URL: #56702 Fixes: #56692 Reviewed-By: James M Snell <jasnell@gmail.com>
diff --git a/src/crypto/crypto_ec.cc b/src/crypto/crypto_ec.cc
@@ -918,6 +918,7 @@ size_t GroupOrderSize(const EVPKeyPointer& key) {
   const EC_KEY* ec = key;
   CHECK_NOT_NULL(ec);
   auto order = BignumPointer::New();
+  CHECK(order);
   CHECK(EC_GROUP_get_order(ECKeyPointer::GetGroup(ec), order.get(), nullptr));
   return order.byteLength();
 }

Original file line number	Diff line number	Diff line change
`@@ -918,6 +918,7 @@ size_t GroupOrderSize(const EVPKeyPointer& key) {`
`918`	`918`	`const EC_KEY* ec = key;`
`919`	`919`	`CHECK_NOT_NULL(ec);`
`920`	`920`	`auto order = BignumPointer::New();`
	`921`	`+ CHECK(order);`
`921`	`922`	`CHECK(EC_GROUP_get_order(ECKeyPointer::GetGroup(ec), order.get(), nullptr));`
`922`	`923`	`return order.byteLength();`
`923`	`924`	`}`