test: use spawnSync() full name

Trott · danielleadams · commit b1e4387c92ed · 2022-01-31T23:54:22.000-05:00
test-cli-bad-options.js uses `spawnSync()` but renames it as `spawn()` which caused me a bit of confusion for a bit until I realized what was going on. Rename the variable `spawnSync()` for readability/maintainability. PR-URL: #41327 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
diff --git a/test/parallel/test-cli-bad-options.js b/test/parallel/test-cli-bad-options.js
@@ -4,7 +4,7 @@ require('../common');
 // Tests that node exits consistently on bad option syntax.
 
 const assert = require('assert');
-const spawn = require('child_process').spawnSync;
+const { spawnSync } = require('child_process');
 
 if (process.features.inspector) {
   requiresArgument('--inspect-port');
@@ -15,7 +15,7 @@ if (process.features.inspector) {
 requiresArgument('--eval');
 
 function requiresArgument(option) {
-  const r = spawn(process.execPath, [option], { encoding: 'utf8' });
+  const r = spawnSync(process.execPath, [option], { encoding: 'utf8' });
 
   assert.strictEqual(r.status, 9);
 
