test: update test-child-process-bad-stdio to use node:test

cjihrig · aduh95 · commit b1c54439aee2 · 2025-01-30T10:44:15.000+01:00
This commit updates test/parallel/test-child-process-bad-stdio.js to use node:test. This change prevents multiple child processes from being spawned in parallel, which can be problematic in the CI. PR-URL: #56562 Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
diff --git a/test/parallel/test-child-process-bad-stdio.js b/test/parallel/test-child-process-bad-stdio.js
@@ -1,21 +1,23 @@
 'use strict';
 // Flags: --expose-internals
 const common = require('../common');
-const assert = require('assert');
-const cp = require('child_process');
 
 if (process.argv[2] === 'child') {
   setTimeout(() => {}, common.platformTimeout(100));
   return;
 }
 
+const assert = require('node:assert');
+const cp = require('node:child_process');
+const { mock, test } = require('node:test');
+const { ChildProcess } = require('internal/child_process');
+
 // Monkey patch spawn() to create a child process normally, but destroy the
 // stdout and stderr streams. This replicates the conditions where the streams
 // cannot be properly created.
-const ChildProcess = require('internal/child_process').ChildProcess;
 const original = ChildProcess.prototype.spawn;
 
-ChildProcess.prototype.spawn = function() {
+mock.method(ChildProcess.prototype, 'spawn', function() {
   const err = original.apply(this, arguments);
 
   this.stdout.destroy();
@@ -24,7 +26,7 @@ ChildProcess.prototype.spawn = function() {
   this.stderr = null;
 
   return err;
-};
+});
 
 function createChild(options, callback) {
   const [cmd, opts] = common.escapePOSIXShell`"${process.execPath}" "${__filename}" child`;
@@ -33,32 +35,32 @@ function createChild(options, callback) {
   return cp.exec(cmd, options, common.mustCall(callback));
 }
 
-// Verify that normal execution of a child process is handled.
-{
+test('normal execution of a child process is handled', (_, done) => {
   createChild({}, (err, stdout, stderr) => {
     assert.strictEqual(err, null);
     assert.strictEqual(stdout, '');
     assert.strictEqual(stderr, '');
+    done();
   });
-}
+});
 
-// Verify that execution with an error event is handled.
-{
+test('execution with an error event is handled', (_, done) => {
   const error = new Error('foo');
   const child = createChild({}, (err, stdout, stderr) => {
     assert.strictEqual(err, error);
     assert.strictEqual(stdout, '');
     assert.strictEqual(stderr, '');
+    done();
   });
 
   child.emit('error', error);
-}
+});
 
-// Verify that execution with a killed process is handled.
-{
+test('execution with a killed process is handled', (_, done) => {
   createChild({ timeout: 1 }, (err, stdout, stderr) => {
     assert.strictEqual(err.killed, true);
     assert.strictEqual(stdout, '');
     assert.strictEqual(stderr, '');
+    done();
   });
-}
+});
