src: turn inspector raw pointer into unique_ptr

fhinkel · gibfahn · commit b1802ede3be1 · 2017-12-13T16:04:13.000Z
Use a unique pointer to make ownership clear. PR-URL: #16974 Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
diff --git a/src/env-inl.h b/src/env-inl.h
@@ -347,8 +347,9 @@ inline Environment::~Environment() {
   v8::HandleScope handle_scope(isolate());
 
 #if HAVE_INSPECTOR
-  // Destroy inspector agent before erasing the context.
-  delete inspector_agent_;
+  // Destroy inspector agent before erasing the context. The inspector
+  // destructor depends on the context still being accessible.
+  inspector_agent_.reset(nullptr);
 #endif
 
   context()->SetAlignedPointerInEmbedderData(kContextEmbedderDataIndex,
diff --git a/src/env.h b/src/env.h
@@ -673,7 +673,7 @@ class Environment {
 
 #if HAVE_INSPECTOR
   inline inspector::Agent* inspector_agent() const {
-    return inspector_agent_;
+    return inspector_agent_.get();
   }
 #endif
 
@@ -718,7 +718,7 @@ class Environment {
   std::map<std::string, uint64_t> performance_marks_;
 
 #if HAVE_INSPECTOR
-  inspector::Agent* const inspector_agent_;
+  std::unique_ptr<inspector::Agent> inspector_agent_;
 #endif
 
   HandleWrapQueue handle_wrap_queue_;
