repl: support hidden history file on Windows

bzoz · evanlucas · commit b09bf51cdfb3 · 2017-05-02T12:46:14.000-05:00
On Windows when REPL history file has the hidden attribute node will fail when trying to open it in 'w' mode. This changes the mode to 'r+'. The file is guaranteed to exists because of earlier open call with 'a+'. Fixes: #5261 PR-URL: #12207 Reviewed-By: James M Snell <jasnell@gmail.com>
diff --git a/lib/internal/repl.js b/lib/internal/repl.js
@@ -165,10 +165,19 @@ function setupHistory(repl, historyPath, oldHistoryPath, ready) {
       }
     }
 
-    fs.open(historyPath, 'w', onhandle);
+    fs.open(historyPath, 'r+', onhandle);
   }
 
   function onhandle(err, hnd) {
+    if (err) {
+      return ready(err);
+    }
+    fs.ftruncate(hnd, 0, (err) => {
+      return onftruncate(err, hnd);
+    });
+  }
+
+  function onftruncate(err, hnd) {
     if (err) {
       return ready(err);
     }
diff --git a/test/fixtures/.empty-hidden-repl-history-file b/test/fixtures/.empty-hidden-repl-history-file
diff --git a/test/parallel/test-repl-persistent-history.js b/test/parallel/test-repl-persistent-history.js
@@ -76,6 +76,8 @@ const oldHistoryPath = path.join(fixtures, 'old-repl-history-file.json');
 const enoentHistoryPath = path.join(fixtures, 'enoent-repl-history-file.json');
 const emptyHistoryPath = path.join(fixtures, '.empty-repl-history-file');
 const defaultHistoryPath = path.join(common.tmpDir, '.node_repl_history');
+const emptyHiddenHistoryPath = path.join(fixtures,
+                                         '.empty-hidden-repl-history-file');
 
 const tests = [
   {
@@ -163,6 +165,19 @@ const tests = [
     test: [UP],
     expected: [prompt, replFailedRead, prompt, replDisabled, prompt]
   },
+  {
+    before: function before() {
+      if (common.isWindows) {
+        const execSync = require('child_process').execSync;
+        execSync(`ATTRIB +H "${emptyHiddenHistoryPath}"`, (err) => {
+          assert.ifError(err);
+        });
+      }
+    },
+    env: { NODE_REPL_HISTORY: emptyHiddenHistoryPath },
+    test: [UP],
+    expected: [prompt]
+  },
   { // Make sure this is always the last test, since we change os.homedir()
     before: function before() {
       // Mock os.homedir() failure

Original file line number	Diff line number	Diff line change
`@@ -165,10 +165,19 @@ function setupHistory(repl, historyPath, oldHistoryPath, ready) {`
`165`	`165`	`}`
`166`	`166`	`}`
`167`	`167`
`168`		`- fs.open(historyPath, 'w', onhandle);`
	`168`	`+ fs.open(historyPath, 'r+', onhandle);`
`169`	`169`	`}`
`170`	`170`
`171`	`171`	`function onhandle(err, hnd) {`
	`172`	`+ if (err) {`
	`173`	`+ return ready(err);`
	`174`	`+ }`
	`175`	`+ fs.ftruncate(hnd, 0, (err) => {`
	`176`	`+ return onftruncate(err, hnd);`
	`177`	`+ });`
	`178`	`+ }`
	`179`	`+`
	`180`	`+ function onftruncate(err, hnd) {`
`172`	`181`	`if (err) {`
`173`	`182`	`return ready(err);`
`174`	`183`	`}`