build: use LC_ALL of C for maximum compatibility

Trott · targos · commit b044256f2a05 · 2018-06-13T08:49:29.000+02:00
LC_ALL=en_US breaks on some systems (notably the SmartOS 16 configuration in our CI). Use LC_ALL=C instead. PR-URL: #21222 Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
diff --git a/configure b/configure
@@ -672,10 +672,7 @@ def get_xcode_version(cc):
 def get_gas_version(cc):
   try:
     custom_env = os.environ.copy()
-    # smartos (a.k.a. sunos5) does not have the en_US locale, and will give:
-    # `setlocale: LC_ALL: cannot change locale (en_US): Invalid argument`
-    if 'sunos' not in sys.platform:
-      custom_env["LC_ALL"] = "en_US"
+    custom_env["LC_ALL"] = "C"
     proc = subprocess.Popen(shlex.split(cc) + ['-Wa,-v', '-c', '-o',
                                                '/dev/null', '-x',
                                                'assembler',  '/dev/null'],
