benchmark: favor === over ==

Trott · Trott · commit ae25ed3ccd8e · 2016-08-09T14:40:01.000-07:00
Refs: #7961 (comment) PR-URL: #8000 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Andreas Madsen <amwebdk@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
diff --git a/benchmark/buffers/buffer-bytelength.js b/benchmark/buffers/buffer-bytelength.js
@@ -50,7 +50,7 @@ function main(conf) {
 }
 
 function buildString(str, times) {
-  if (times == 1) return str;
+  if (times === 1) return str;
 
   return str + buildString(str, times - 1);
 }
diff --git a/benchmark/crypto/cipher-stream.js b/benchmark/crypto/cipher-stream.js
@@ -31,7 +31,7 @@ function main(conf) {
   var bob_secret = bob.computeSecret(alice.getPublicKey(), pubEnc, 'hex');
 
   // alice_secret and bob_secret should be the same
-  assert(alice_secret == bob_secret);
+  assert(alice_secret === bob_secret);
 
   var alice_cipher = crypto.createCipher(conf.cipher, alice_secret);
   var bob_cipher = crypto.createDecipher(conf.cipher, bob_secret);
diff --git a/benchmark/dgram/array-vs-concat.js b/benchmark/dgram/array-vs-concat.js
@@ -46,14 +46,14 @@ function server() {
   var onsend = type === 'concat' ? onsendConcat : onsendMulti;
 
   function onsendConcat() {
-    if (sent++ % num == 0)
+    if (sent++ % num === 0)
       for (var i = 0; i < num; i++) {
         socket.send(Buffer.concat(chunk), PORT, '127.0.0.1', onsend);
       }
   }
 
   function onsendMulti() {
-    if (sent++ % num == 0)
+    if (sent++ % num === 0)
       for (var i = 0; i < num; i++) {
         socket.send(chunk, PORT, '127.0.0.1', onsend);
       }
diff --git a/benchmark/dgram/multi-buffer.js b/benchmark/dgram/multi-buffer.js
@@ -45,7 +45,7 @@ function server() {
   var socket = dgram.createSocket('udp4');
 
   function onsend() {
-    if (sent++ % num == 0)
+    if (sent++ % num === 0)
       for (var i = 0; i < num; i++)
         socket.send(chunk, PORT, '127.0.0.1', onsend);
   }
diff --git a/benchmark/dgram/offset-length.js b/benchmark/dgram/offset-length.js
@@ -37,7 +37,7 @@ function server() {
   var socket = dgram.createSocket('udp4');
 
   function onsend() {
-    if (sent++ % num == 0)
+    if (sent++ % num === 0)
       for (var i = 0; i < num; i++)
         socket.send(chunk, 0, chunk.length, PORT, '127.0.0.1', onsend);
   }
diff --git a/benchmark/dgram/single-buffer.js b/benchmark/dgram/single-buffer.js
@@ -37,7 +37,7 @@ function server() {
   var socket = dgram.createSocket('udp4');
 
   function onsend() {
-    if (sent++ % num == 0)
+    if (sent++ % num === 0)
       for (var i = 0; i < num; i++)
         socket.send(chunk, PORT, '127.0.0.1', onsend);
   }
diff --git a/benchmark/http/_http_simple.js b/benchmark/http/_http_simple.js
@@ -37,7 +37,7 @@ var server = module.exports = http.createServer(function(req, res) {
   var status = 200;
 
   var n, i;
-  if (command == 'bytes') {
+  if (command === 'bytes') {
     n = ~~arg;
     if (n <= 0)
       throw new Error('bytes called with n <= 0');
@@ -46,7 +46,7 @@ var server = module.exports = http.createServer(function(req, res) {
     }
     body = storedBytes[n];
 
-  } else if (command == 'buffer') {
+  } else if (command === 'buffer') {
     n = ~~arg;
     if (n <= 0)
       throw new Error('buffer called with n <= 0');
@@ -58,7 +58,7 @@ var server = module.exports = http.createServer(function(req, res) {
     }
     body = storedBuffer[n];
 
-  } else if (command == 'unicode') {
+  } else if (command === 'unicode') {
     n = ~~arg;
     if (n <= 0)
       throw new Error('unicode called with n <= 0');
@@ -67,14 +67,14 @@ var server = module.exports = http.createServer(function(req, res) {
     }
     body = storedUnicode[n];
 
-  } else if (command == 'quit') {
+  } else if (command === 'quit') {
     res.connection.server.close();
     body = 'quitting';
 
-  } else if (command == 'fixed') {
+  } else if (command === 'fixed') {
     body = fixed;
 
-  } else if (command == 'echo') {
+  } else if (command === 'echo') {
     res.writeHead(200, { 'Content-Type': 'text/plain',
                          'Transfer-Encoding': 'chunked' });
     req.pipe(res);

Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,7 @@ function main(conf) {`
`50`	`50`	`}`
`51`	`51`
`52`	`52`	`function buildString(str, times) {`
`53`		`- if (times == 1) return str;`
	`53`	`+ if (times === 1) return str;`
`54`	`54`
`55`	`55`	`return str + buildString(str, times - 1);`
`56`	`56`	`}`
Original file line number	Diff line number	Diff line change
`@@ -46,14 +46,14 @@ function server() {`
`46`	`46`	`var onsend = type === 'concat' ? onsendConcat : onsendMulti;`
`47`	`47`
`48`	`48`	`function onsendConcat() {`
`49`		`- if (sent++ % num == 0)`
	`49`	`+ if (sent++ % num === 0)`
`50`	`50`	`for (var i = 0; i < num; i++) {`
`51`	`51`	`socket.send(Buffer.concat(chunk), PORT, '127.0.0.1', onsend);`
`52`	`52`	`}`
`53`	`53`	`}`
`54`	`54`
`55`	`55`	`function onsendMulti() {`
`56`		`- if (sent++ % num == 0)`
	`56`	`+ if (sent++ % num === 0)`
`57`	`57`	`for (var i = 0; i < num; i++) {`
`58`	`58`	`socket.send(chunk, PORT, '127.0.0.1', onsend);`
`59`	`59`	`}`
Original file line number	Diff line number	Diff line change
`@@ -45,7 +45,7 @@ function server() {`
`45`	`45`	`var socket = dgram.createSocket('udp4');`
`46`	`46`
`47`	`47`	`function onsend() {`
`48`		`- if (sent++ % num == 0)`
	`48`	`+ if (sent++ % num === 0)`
`49`	`49`	`for (var i = 0; i < num; i++)`
`50`	`50`	`socket.send(chunk, PORT, '127.0.0.1', onsend);`
`51`	`51`	`}`
Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,7 @@ function server() {`
`37`	`37`	`var socket = dgram.createSocket('udp4');`
`38`	`38`
`39`	`39`	`function onsend() {`
`40`		`- if (sent++ % num == 0)`
	`40`	`+ if (sent++ % num === 0)`
`41`	`41`	`for (var i = 0; i < num; i++)`
`42`	`42`	`socket.send(chunk, 0, chunk.length, PORT, '127.0.0.1', onsend);`
`43`	`43`	`}`