lib: add validation for options in compileFunction

kimtaejin3 · marco-ippolito · commit ac57dadd9a3c · 2025-01-24T22:18:52.000+01:00
PR-URL: #56023 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
diff --git a/lib/vm.js b/lib/vm.js
@@ -319,6 +319,7 @@ function runInThisContext(code, options) {
 
 function compileFunction(code, params, options = kEmptyObject) {
   validateString(code, 'code');
+  validateObject(options, 'options');
   if (params !== undefined) {
     validateStringArray(params, 'params');
   }
diff --git a/test/parallel/test-vm-basic.js b/test/parallel/test-vm-basic.js
@@ -172,7 +172,30 @@ const vm = require('vm');
       'Received null'
   });
 
-  // vm.compileFunction('', undefined, null);
+  // Test for invalid options type
+  assert.throws(() => {
+    vm.compileFunction('', [], null);
+  }, {
+    name: 'TypeError',
+    code: 'ERR_INVALID_ARG_TYPE',
+    message: 'The "options" argument must be of type object. Received null'
+  });
+
+  assert.throws(() => {
+    vm.compileFunction('', [], 'string');
+  }, {
+    name: 'TypeError',
+    code: 'ERR_INVALID_ARG_TYPE',
+    message: 'The "options" argument must be of type object. Received type string (\'string\')'
+  });
+
+  assert.throws(() => {
+    vm.compileFunction('', [], 123);
+  }, {
+    name: 'TypeError',
+    code: 'ERR_INVALID_ARG_TYPE',
+    message: 'The "options" argument must be of type object. Received type number (123)'
+  });
 
   const optionTypes = {
     'filename': 'string',

Original file line number	Diff line number	Diff line change
`@@ -319,6 +319,7 @@ function runInThisContext(code, options) {`
`319`	`319`
`320`	`320`	`function compileFunction(code, params, options = kEmptyObject) {`
`321`	`321`	`validateString(code, 'code');`
	`322`	`+ validateObject(options, 'options');`
`322`	`323`	`if (params !== undefined) {`
`323`	`324`	`validateStringArray(params, 'params');`
`324`	`325`	`}`