stream: don't try to read more if reading

ronag · aduh95 · commit ac3dbe48f7c2 · 2025-11-13T22:44:14.000+01:00
Avoid unnecessary nextTick. PR-URL: #60454 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
diff --git a/lib/internal/streams/readable.js b/lib/internal/streams/readable.js
@@ -853,7 +853,7 @@ function emitReadable_(stream) {
 // However, if we're not ended, or reading, and the length < hwm,
 // then go ahead and try to read some more preemptively.
 function maybeReadMore(stream, state) {
-  if ((state[kState] & (kReadingMore | kConstructed)) === kConstructed) {
+  if ((state[kState] & (kReadingMore | kReading | kConstructed)) === kConstructed) {
     state[kState] |= kReadingMore;
     process.nextTick(maybeReadMore_, stream, state);
   }

Original file line number	Diff line number	Diff line change
`@@ -853,7 +853,7 @@ function emitReadable_(stream) {`
`853`	`853`	`// However, if we're not ended, or reading, and the length < hwm,`
`854`	`854`	`// then go ahead and try to read some more preemptively.`
`855`	`855`	`function maybeReadMore(stream, state) {`
`856`		`- if ((state[kState] & (kReadingMore \| kConstructed)) === kConstructed) {`
	`856`	`+ if ((state[kState] & (kReadingMore \| kReading \| kConstructed)) === kConstructed) {`
`857`	`857`	`state[kState] \|= kReadingMore;`
`858`	`858`	`process.nextTick(maybeReadMore_, stream, state);`
`859`	`859`	`}`