perf_hooks: add missing type argument to getEntriesByName

luketaher · marco-ippolito · commit ac1cb8dfdbfc · 2024-11-17T11:51:37.000+01:00
Fixes: #54766 PR-URL: #54767 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
diff --git a/lib/internal/perf/performance.js b/lib/internal/perf/performance.js
@@ -97,13 +97,16 @@ class Performance extends EventTarget {
     return filterBufferMapByNameAndType();
   }
 
-  getEntriesByName(name) {
+  getEntriesByName(name, type = undefined) {
     validateInternalField(this, kPerformanceBrand, 'Performance');
     if (arguments.length === 0) {
       throw new ERR_MISSING_ARGS('name');
     }
     name = `${name}`;
-    return filterBufferMapByNameAndType(name, undefined);
+    if (type !== undefined) {
+      type = `${type}`;
+    }
+    return filterBufferMapByNameAndType(name, type);
   }
 
   getEntriesByType(type) {
diff --git a/test/parallel/test-performance-timeline.mjs b/test/parallel/test-performance-timeline.mjs
@@ -33,6 +33,12 @@ await setTimeout(50);
 performance.measure('a', 'one');
 const entriesByName = performance.getEntriesByName('a');
 assert.deepStrictEqual(entriesByName.map((x) => x.entryType), ['measure', 'mark', 'measure', 'mark']);
+const marksByName = performance.getEntriesByName('a', 'mark');
+assert.deepStrictEqual(marksByName.map((x) => x.entryType), ['mark', 'mark']);
+const measuresByName = performance.getEntriesByName('a', 'measure');
+assert.deepStrictEqual(measuresByName.map((x) => x.entryType), ['measure', 'measure']);
+const invalidTypeEntriesByName = performance.getEntriesByName('a', null);
+assert.strictEqual(invalidTypeEntriesByName.length, 0);
 
 // getEntriesBy[Name|Type](undefined)
 performance.mark(undefined);

Original file line number	Diff line number	Diff line change
`@@ -97,13 +97,16 @@ class Performance extends EventTarget {`
`97`	`97`	`return filterBufferMapByNameAndType();`
`98`	`98`	`}`
`99`	`99`
`100`		`- getEntriesByName(name) {`
	`100`	`+ getEntriesByName(name, type = undefined) {`
`101`	`101`	`validateInternalField(this, kPerformanceBrand, 'Performance');`
`102`	`102`	`if (arguments.length === 0) {`
`103`	`103`	`throw new ERR_MISSING_ARGS('name');`
`104`	`104`	`}`
`105`	`105`	name = `${name}`;
`106`		`- return filterBufferMapByNameAndType(name, undefined);`
	`106`	`+ if (type !== undefined) {`
	`107`	+ type = `${type}`;
	`108`	`+ }`
	`109`	`+ return filterBufferMapByNameAndType(name, type);`
`107`	`110`	`}`
`108`	`111`
`109`	`112`	`getEntriesByType(type) {`