benchmark: avoid input param manipulation

MrJithil · danielleadams · commit abe2eb9fc097 · 2022-03-14T09:32:18.000-04:00
PR-URL: #41741 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: James M Snell <jasnell@gmail.com>
diff --git a/benchmark/assert/deepequal-object.js b/benchmark/assert/deepequal-object.js
@@ -24,8 +24,7 @@ function createObj(source, add = '') {
 }
 
 function main({ size, n, method, strict }) {
-  // TODO: Fix this "hack". `n` should not be manipulated.
-  n = Math.min(Math.ceil(n / size), 20);
+  const len = Math.min(Math.ceil(n / size), 20);
 
   const source = Array.apply(null, Array(size));
   const actual = createObj(source);
@@ -39,8 +38,8 @@ function main({ size, n, method, strict }) {
   const value2 = method.includes('not') ? expectedWrong : expected;
 
   bench.start();
-  for (let i = 0; i < n; ++i) {
+  for (let i = 0; i < len; ++i) {
     fn(actual, value2);
   }
-  bench.end(n);
+  bench.end(len);
 }

Original file line number	Diff line number	Diff line change
`@@ -24,8 +24,7 @@ function createObj(source, add = '') {`
`24`	`24`	`}`
`25`	`25`
`26`	`26`	`function main({ size, n, method, strict }) {`
`27`		- // TODO: Fix this "hack". `n` should not be manipulated.
`28`		`- n = Math.min(Math.ceil(n / size), 20);`
	`27`	`+ const len = Math.min(Math.ceil(n / size), 20);`
`29`	`28`
`30`	`29`	`const source = Array.apply(null, Array(size));`
`31`	`30`	`const actual = createObj(source);`
`@@ -39,8 +38,8 @@ function main({ size, n, method, strict }) {`
`39`	`38`	`const value2 = method.includes('not') ? expectedWrong : expected;`
`40`	`39`
`41`	`40`	`bench.start();`
`42`		`- for (let i = 0; i < n; ++i) {`
	`41`	`+ for (let i = 0; i < len; ++i) {`
`43`	`42`	`fn(actual, value2);`
`44`	`43`	`}`
`45`		`- bench.end(n);`
	`44`	`+ bench.end(len);`
`46`	`45`	`}`