util: convert inspect.styles and inspect.colors to prototype-less objects

Nemanja Stojanovic · jasnell · commit aab0d202f8ed · 2017-03-06T13:14:07.000-08:00
Use a prototype-less object for inspect.styles and inspect.colors to allow modification of Object.prototype in the REPL. Fixes: #11614 PR-URL: #11624 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com>
diff --git a/lib/util.js b/lib/util.js
@@ -166,7 +166,7 @@ Object.defineProperty(inspect, 'defaultOptions', {
 });
 
 // http://en.wikipedia.org/wiki/ANSI_escape_code#graphics
-inspect.colors = {
+inspect.colors = Object.assign(Object.create(null), {
   'bold': [1, 22],
   'italic': [3, 23],
   'underline': [4, 24],
@@ -180,10 +180,10 @@ inspect.colors = {
   'magenta': [35, 39],
   'red': [31, 39],
   'yellow': [33, 39]
-};
+});
 
 // Don't use 'blue' not visible on cmd.exe
-inspect.styles = {
+inspect.styles = Object.assign(Object.create(null), {
   'special': 'cyan',
   'number': 'yellow',
   'boolean': 'yellow',
@@ -194,7 +194,7 @@ inspect.styles = {
   'date': 'magenta',
   // "name": intentionally not styling
   'regexp': 'red'
-};
+});
 
 const customInspectSymbol = internalUtil.customInspectSymbol;
 
